diff --git a/api/tests/test_event_results.py b/api/tests/test_event_results.py index f969a632a5bf8a0ee0c28131c0711d23dfbf7d5f..38159b7f563d3b9eb84af609d41c7bdc1e121801 100644 --- a/api/tests/test_event_results.py +++ b/api/tests/test_event_results.py @@ -108,7 +108,7 @@ class TestEventResultsAPI(APITestCase): self.assertTrue(player.eventplayerresult_set.exists()) def test_send_results_player_clean_name(self): - player = PlayerFactory() + player = PlayerFactory(name="Antoine Albertelli") self.client.login(**self.credentials) data = { "results": [ @@ -124,7 +124,10 @@ class TestEventResultsAPI(APITestCase): resp = self.client.patch(self.url, data=data, format="json") # Check that the event got associated with the player - self.assertTrue(player.eventplayerresult_set.exists()) + self.assertTrue( + player.eventplayerresult_set.exists(), + f"Should have results for {player.name}", + ) def test_upload_deletes_old_results(self): player = PlayerFactory() diff --git a/championship/views/results.py b/championship/views/results.py index da368d9c1f76b2e660980e469de4336c2bcf1d79..f76c84f4776e4ed69cbed02e6b758e240ecced10 100644 --- a/championship/views/results.py +++ b/championship/views/results.py @@ -122,12 +122,16 @@ def clean_name(name: str) -> str: >>> clean_name('antoine albertelli') 'Antoine Albertelli' - Note lower case words are only capitalized if the word has more than 3 letters (Short terms like "van", ""der", "da" shouldn't be capital). >>> clean_name('Antoine van Albertelli') 'Antoine van Albertelli' + #Â TODO: Shorter first names like Joe will not be capitalized correctly for + now as they are assumed to be particles, like "von", "de" or "van". + #Â >>> clean_name('joe uldry') + #Â 'Joe Uldry' + >>> clean_name('Antoine J. Albertelli') 'Antoine J. Albertelli' """